Replaced Checkbox with MUI Checkbox #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abigailalexander
requested changes
Mar 31, 2025
There was a problem hiding this comment.
Looks good overall, I only had a few small comments that are quite similar to those on the ActionButton PR.
I did notice that the Checkbox doesn't seem to be located correctly in the page, it's setting some padding that makes it shift down and to the right of where it should be compared to Phoebus (see images - left is the size and position of the widget as defined in Phoebus, right shows how the padding is forcing the entire component including the label to be shifted)
 |
 |
|---|
There was a problem hiding this comment.
Thanks for fixing those other items. Just the issue with the padding/sizing of the checkbox that I mentioned to you remaining. From what I saw when I looked into it:
- Unneeded padding on the MUI Checkbox component itself
- Unnecessary right-side margin on the MUI Form Control element
- Some sort of size restriction that doesn't allow the Checkbox Icon to go small enough. It seems like it might be one of the MUI internal components that needs adjusting e.g.
MuiCheckbox-root
abigailalexander
approved these changes
Apr 9, 2025
NatLeung96
added a commit
that referenced
this pull request
Apr 10, 2025
* Replaced Checkbox with MUI Checkbox * Removed ThemeProvider and added additional styling to FormControlLabel * Moved static styling to styled API. Not-allowed cursor when widget is disabled. Added font styling. * Removed padding * Removed padding and fixed alignments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.